Conversation
Deploying drive-web with
|
| Latest commit: |
2ebde1f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dde9e286.drive-web.pages.dev |
| Branch Preview URL: | https://refactor-remove-dead-code.drive-web.pages.dev |
|
WDYT @CandelR ? |
CandelR
left a comment
CandelR
left a comment
There was a problem hiding this comment.
@sg-gs I understand that it is a tool or AI that you have tried out to see how well it works for cleaning code, is that right?
It seems to do a good job of removing unused code. The only thing missing is some context about certain components. For example, in the Workspaces (B2B) section, there are some that are not used, but they were created at the time because there is a design, and I think that if B2B is continued, they will be used.
It also seems that it does not take into account orphaned translations.
But it does take into account tests of code that is not used, and deletes the code and the corresponding tests.
So it's not bad 👌
| onSavingAvatarError: (error: unknown) => void; | ||
| } | ||
|
|
||
| const UploadWorkspaceAvatarModal = ({ |
There was a problem hiding this comment.
@larry-internxt Do you remember why this component is not used?
There was a problem hiding this comment.
@larry-internxt Do you remember why this component is not used?
No I dont remember why
ps: that is not my current account hahaha that account doesnt ping me
| {!isUserTeams && isTeams && ( | ||
| <section className="flex h-40 w-full flex-col items-center justify-center rounded-xl border border-gray-10 bg-gray-1 py-10"> | ||
| <p className="font-regular text-center text-base text-gray-50"> | ||
| {t('preferences.workspace.members.tabs.teams.emptyTeams.title')} |
There was a problem hiding this comment.
nit: that translation seems unused after this component remove
|
As long as it is not currently needed, I will just wipe out that code. Once the moment arrives, we can rescue it from the corresponding PR, meanwhile, it is noise and contributes negatively to the coverage and maintenance of this project, I think @CandelR |
|
I am pretty sure I can wipe out another thousand lines, but I did not want to create a massive PR :) |
|
Waiting for the rest of the reviewers @xabg2 @TamaraFinogina @larry-internxt @jaaaaavier |
| export type Views = 'general' | 'invite' | 'requests'; | ||
| export type RequestStatus = 'pending' | 'accepted' | 'denied'; | ||
|
|
||
| export const REQUEST_STATUS = { |
There was a problem hiding this comment.
It seems to be still expected in tests:
TamaraFinogina
left a comment
TamaraFinogina
left a comment
There was a problem hiding this comment.
Tests are failing. Some are missing REQUEST_STATUS, so returning it should fix at least some of the tests.
|
P.S. Sonar complains about 6 unused imports, we can clean them up too |
|
Let's close this first @TamaraFinogina. Waiting your review @jaaaaavier |
|
6 participants
Description
Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes